Skip to content

Conversation

@thiswillbeyourgithub
Copy link
Contributor

  • add a type hint
  • add parallel processing of chunk via joblib

For #178

I haven't tested it but it looked correct.

Signed-off-by: thiswillbeyourgithub <[email protected]>
@absadiki
Copy link
Owner

absadiki commented Sep 4, 2025

Looks great! Thanks @thiswillbeyourgithub.
But It’d be better if you could take a bit of time to test it as well, just to make sure everything works as expected 😅

@thiswillbeyourgithub
Copy link
Contributor Author

I just tested the code and it worked fine. I don't seem to get the "print" appear in the docker logs, I recommend using loguru for this.

@absadiki
Copy link
Owner

absadiki commented Sep 9, 2025

Yes, using a logger is always better than using the simple prints.
Thanks a lot for testing. I'll go ahead and merge this for now.

@absadiki absadiki merged commit ef00dc2 into absadiki:main Sep 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants